-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add __getnewargs__ to SpanContext class #1380
Add __getnewargs__ to SpanContext class #1380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting. Just out of curiosity, what was the use case that made you open this PR, @rickychu?
I have a multiprocessing script where the pools need to continue with the span context so it has to be pickled.
Error: It works in 0.13b0 with span.get_context() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Description
SpanContext does not support pickle due to missing getnewargs function. Add function to SpanContext.
Fixes # (issue)
#1375
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist: