-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canceled: Add __getnewargs__ to SpanContext class to support pickle #1379
Closed
rickychu
wants to merge
7
commits into
open-telemetry:master
from
rickychu:bug_1375_unable_to_pickle_spancontext
Closed
Canceled: Add __getnewargs__ to SpanContext class to support pickle #1379
rickychu
wants to merge
7
commits into
open-telemetry:master
from
rickychu:bug_1375_unable_to_pickle_spancontext
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickychu
requested review from
a team,
owais and
lzchen
and removed request for
a team
November 13, 2020 02:01
|
|
2 similar comments
|
|
|
|
|
|
|
rickychu
changed the title
Add __getnewargs__ and __reduce__ to support pickle
Add __getnewargs__ to SpanContext class to support pickle
Nov 13, 2020
rickychu
changed the title
Add __getnewargs__ to SpanContext class to support pickle
Canceled: Add __getnewargs__ to SpanContext class to support pickle
Nov 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SpanContext does not support pickle due to missing getnewargs. Add it to the SpanContext class
Fixes # (issue)
#1375
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Create SpanContext class and use pickle.dumps and pickle.loads without issue
Checklist: