Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canceled: Add __getnewargs__ to SpanContext class to support pickle #1379

Closed
wants to merge 7 commits into from
Closed

Canceled: Add __getnewargs__ to SpanContext class to support pickle #1379

wants to merge 7 commits into from

Conversation

rickychu
Copy link
Contributor

@rickychu rickychu commented Nov 13, 2020

Description

SpanContext does not support pickle due to missing getnewargs. Add it to the SpanContext class

Fixes # (issue)

#1375

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Create SpanContext class and use pickle.dumps and pickle.loads without issue

  • Tor

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@rickychu rickychu requested review from a team, owais and lzchen and removed request for a team November 13, 2020 02:01
@linux-foundation-easycla
Copy link

CLA Missing ID

@linux-foundation-easycla
Copy link

CLA Missing ID

2 similar comments
@linux-foundation-easycla
Copy link

CLA Missing ID

@linux-foundation-easycla
Copy link

CLA Missing ID

@linux-foundation-easycla
Copy link

CLA Missing ID

@linux-foundation-easycla
Copy link

CLA Missing ID

@linux-foundation-easycla
Copy link

CLA Missing ID

@linux-foundation-easycla
Copy link

CLA Missing ID

@linux-foundation-easycla
Copy link

CLA Missing ID

@rickychu rickychu changed the title Add __getnewargs__ and __reduce__ to support pickle Add __getnewargs__ to SpanContext class to support pickle Nov 13, 2020
@rickychu rickychu closed this Nov 13, 2020
@rickychu rickychu changed the title Add __getnewargs__ to SpanContext class to support pickle Canceled: Add __getnewargs__ to SpanContext class to support pickle Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant