Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing TracerProvider coupling from Tracer init (#1181) #1295

Conversation

robwknox
Copy link
Contributor

@robwknox robwknox commented Oct 28, 2020

Description

Removes coupling of TracerProvider in Tracer() by explicitly passing in tracer dependencies instead of a TracerProvider object.

Fixes (#1181)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

tox full run against envs:

  • 3.5.10
  • 3.6.12
  • 3.7.9
  • 3.8.6
  • 3.9.0
  • pypy3.6-7.3.1

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@robwknox robwknox requested review from a team, toumorokoshi and aabmass and removed request for a team October 28, 2020 18:43
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks.

@lzchen lzchen added the release:required-for-ga To be resolved before GA release label Oct 29, 2020
@codeboten codeboten merged commit ce515a0 into open-telemetry:master Nov 2, 2020
@robwknox robwknox changed the title Removing TracerProvider coupling from Tracer init Removing TracerProvider coupling from Tracer init (#1181) Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:required-for-ga To be resolved before GA release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants