Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Span.is_recording() now based off self._end_time and returns False if… #1289

Merged
merged 3 commits into from
Oct 29, 2020
Merged

Span.is_recording() now based off self._end_time and returns False if… #1289

merged 3 commits into from
Oct 29, 2020

Conversation

robwknox
Copy link
Contributor

@robwknox robwknox commented Oct 27, 2020 •
edited
Loading

… span has ended

Description

Span.is_recording() is now based off self._end_time and returns False if a span has ended.

Fixes (#1243)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

tox full run against pyenvs:

  • 3.5.10
  • 3.6.12
  • 3.7.9
  • 3.8.6
  • 3.9.0
  • pypy3.6-7.3.1

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@robwknox robwknox requested review from a team, owais and hectorhdzg and removed request for a team October 27, 2020 17:12
codeboten
codeboten approved these changes Oct 27, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change, I agree that this is a much simpler implementation 👍

@lzchen lzchen merged commit bcc53c8 into open-telemetry:master Oct 29, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
@markwolff @mayurkale22
fix(grpc): camelCase methods can be double patched (open-telemetry#1289)
bd03c89 
Co-authored-by: Mayur Kale <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@lzchen lzchen lzchen approved these changes

@owais owais Awaiting requested review from owais

@hectorhdzg hectorhdzg Awaiting requested review from hectorhdzg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robwknox @codeboten @lzchen