-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move aiohttp-client instrumentation package to Contrib Repo #1261
Move aiohttp-client instrumentation package to Contrib Repo #1261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the title to reflect that this instrumentation is moving to the contrib repo, will make it easier for people looking for it :)
@codeboten Sounds good, updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed the docs entry for this was removed but not re-introduced in the contrib repo, anby thoughts on the path forward here is?
@codeboten I was thinking about that too and was going to bring it up in the SIG meeting. I was going to update this PR to remove the non Let me know what you think of that! It will make the “remove” PRs in the Core repo here as straightforward as the Contrib ones. And it’s the solution I prefer. Because an extra commit to remove them would have to be reviewed carefully I would think, but with the 2 PRs we can directly compre the differences. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking on merging this until the contrib repo is running CI and we have all the tools over there.
Going to close this PR because based on the SIG meeting today we agreed that once we have CI tests passing on Contrib we can just delete all the packages in one PR here. |
Description
Follow up to open-telemetry/opentelemetry-python-contrib#49
How Has This Been Tested?
CI has been updated to remove package tests (since they will live in the Contrib repo instead)
Checklist:
- [ ] Unit tests have been added- [ ] Documentation has been updated