Removes Instrumentation and Exporter Code From Core Repo #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR will be closed in favor of several smaller PRs! |
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
…se (open-telemetry#1258) Co-authored-by: Daniel Dyla <[email protected]>
NathanielRN
force-pushed
the
remove-contrib-files
branch
2 times, most recently
from
4073ddb to
be1ec92
Compare
codeboten
suggested changes
Nov 3, 2020
| -e {toxinidir}/instrumentation/opentelemetry-instrumentation-wsgi \ | ||
| -e {toxinidir}/instrumentation/opentelemetry-instrumentation-flask | ||
| -e {toxinidir}/opentelemetry-python-contrib/instrumentation/opentelemetry-instrumentation-requests \ | ||
| -e {toxinidir}/opentelemetry-python-contrib/instrumentation/opentelemetry-instrumentation-wsgi |
There was a problem hiding this comment.
I removed it because I noticed that tests/w3c_tracecontext_validation_server.py didn't use opentelemetry.instrumentation.flask. Not sure if it uses it in auto-instrumentation but I will experiment with it today to find out if it's needed.
There was a problem hiding this comment.
Turns out its not needed!
NathanielRN
force-pushed
the
remove-contrib-files
branch
17 times, most recently
from
ff3802f to
4345c41
Compare
NathanielRN
commented
Nov 4, 2020
| -e {toxinidir}/instrumentation/opentelemetry-instrumentation-wsgi \ | ||
| -e {toxinidir}/instrumentation/opentelemetry-instrumentation-flask | ||
| -e {toxinidir}/opentelemetry-python-contrib/instrumentation/opentelemetry-instrumentation-requests \ | ||
| -e {toxinidir}/opentelemetry-python-contrib/instrumentation/opentelemetry-instrumentation-wsgi |
There was a problem hiding this comment.
Turns out its not needed!
NathanielRN
force-pushed
the
remove-contrib-files
branch
3 times, most recently
from
bda99f5 to
0c38760
Compare
NathanielRN
requested review from
a team,
codeboten and
hectorhdzg
and removed request for
a team
aabmass
requested changes
Nov 4, 2020
NathanielRN
force-pushed
the
remove-contrib-files
branch
from
3f091b2 to
52ca433
Compare
4 tasks
NathanielRN
force-pushed
the
remove-contrib-files
branch
6 times, most recently
from
3a5aa01 to
b0eb8f0
Compare
codeboten
approved these changes
Nov 5, 2020
NathanielRN
force-pushed
the
remove-contrib-files
branch
from
b0eb8f0 to
036e98f
Compare
4 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes code that will be destined for the Contrib Repository as outlined in this PR.
Fixes #1233
Type of change
Moving files to another repo without breaking API calls
How Has This Been Tested?
The Contrib repo has a CI build to validate changes there use the APIs and SDK here.
Checklist:
- [ ] Unit tests have been added- [] Documentation has been updated