-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow None in sequence attributes values (#998) #1256
Allow None in sequence attributes values (#998) #1256
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, just a couple of non-blocking suggestions
b0ff611
to
71b6174
Compare
Erk, a step failed. It looks like a flaky Flask test. I cannot get CircleCI to relaunch the pipeline tho...
|
be4efc9
to
621a18e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just need to update the Attributes
type
Sequence[str], | |
Sequence[bool], | |
Sequence[int], | |
Sequence[float], |
ede3d8b
to
6365549
Compare
6365549
to
206b5c1
Compare
…llectorTraceExporter (open-telemetry#1256)
Description
As per the spec, None values in attribute sequences are valid
Fixes #998
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit tests have been added
Checklist: