Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add optional parameter to record_exception method #1242

Merged
merged 9 commits into from
Nov 3, 2020
Merged

add optional parameter to record_exception method #1242

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
63f57b6
add optional parameter to record_exception method
shreyagupta30 Oct 14, 2020
45583d1
update sdk/trace/init.py and Changelog
shreyagupta30 Oct 14, 2020
845c257
fix imports error
shreyagupta30 Oct 14, 2020
8ddb574
fix imports error
shreyagupta30 Oct 14, 2020
e001ccb
fix paramter override in record_exception()
shreyagupta30 Oct 14, 2020
0262b64
Merge branch 'master' into record-exception
Oct 14, 2020
b8c5b85
Merge branch 'master' into record-exception
Oct 29, 2020
f4bbe2e
Merge branch 'master' into record-exception
lzchen Nov 2, 2020
ef33e45
Merge branch 'master' into record-exception
lzchen Nov 3, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion opentelemetry-api/src/opentelemetry/trace/span.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,12 @@ def set_status(self, status: Status) -> None:
"""

@abc.abstractmethod
def record_exception(self, exception: Exception) -> None:
def record_exception(
self,
exception: Exception,
attributes: types.Attributes = None,
timestamp: typing.Optional[int] = None,
) -> None:
"""Records an exception as a span event."""

def __enter__(self) -> "Span":
Expand Down