Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use is_recording flag in aiopg, asyncpg, dbapi, psycopg2, pymemcache, pymongo, redis, sqlalchemy instrumentations #1212

Merged
merged 15 commits into from
Oct 8, 2020
Merged

Use is_recording flag in aiopg, asyncpg, dbapi, psycopg2, pymemcache, pymongo, redis, sqlalchemy instrumentations #1212

merged 15 commits into from
Oct 8, 2020

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Oct 7, 2020

Part of #1057

@lzchen lzchen requested a review from a team October 7, 2020 18:02
ocelotl
ocelotl approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@ocelotl ocelotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nit only.

instrumentation/opentelemetry-instrumentation-aiopg/tests/test_aiopg_integration.py Outdated Show resolved Hide resolved
codeboten
codeboten approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...tion/opentelemetry-instrumentation-aiopg/src/opentelemetry/instrumentation/aiopg/wrappers.py Outdated Show resolved Hide resolved
...tion/opentelemetry-instrumentation-aiopg/src/opentelemetry/instrumentation/aiopg/wrappers.py Outdated Show resolved Hide resolved
@codeboten codeboten added the release:required-for-ga To be resolved before GA release label Oct 8, 2020
@codeboten codeboten self-assigned this Oct 8, 2020
@lzchen lzchen merged commit affe911 into open-telemetry:master Oct 8, 2020
@lzchen lzchen deleted the record branch October 8, 2020 19:25
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
@renovate-bot
fix(deps): pin dependencies (open-telemetry#1212)
7afc454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocelotl ocelotl ocelotl approved these changes

@codeboten codeboten codeboten approved these changes

@owais owais owais approved these changes

Assignees

@codeboten codeboten

Labels
release:required-for-ga To be resolved before GA release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lzchen @owais @codeboten @ocelotl