Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instrumentation info to exported spans #1095

Merged
merged 4 commits into from
Sep 14, 2020
Merged

Add instrumentation info to exported spans #1095

merged 4 commits into from
Sep 14, 2020

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Sep 10, 2020

Fixes #1094

@ocelotl ocelotl requested a review from a team September 10, 2020 22:12
@ocelotl ocelotl self-assigned this Sep 10, 2020
codeboten
codeboten approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, could you update the changelog?

@ocelotl
Copy link
Contributor Author

ocelotl commented Sep 14, 2020

Nice, could you update the changelog?

Done

@codeboten codeboten merged commit 1e34279 into open-telemetry:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@codeboten codeboten codeboten approved these changes

Assignees

@ocelotl ocelotl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OTLP Exporter should report instrumentation info
3 participants
@ocelotl @codeboten @lzchen