-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align sampling specs in SDK #1034
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the changes here look good, couple of minor suggestions/questions.
Should ParentOrElse
be ParentBased
? Looking at the spec, it looks like it was renamed: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk.md#parentbased
Also looks like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good, thanks for the update!
Description
Part of #906 to adhere to https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk.md#sampling
Updates classes to adhere to the sampling spec.
Fixes # (issue)
Sampling changes
TODO