-
Notifications
You must be signed in to change notification settings - Fork 651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix grpc tests when running from cmd-line/eachdist script #1027
Conversation
* when running the grpc tests with pytest or eachdist from the command line the 2nd test trying to connect to the test server failed with a connection refused message. Seems like the connection from the previous test was still alive due to the channel not being properly closed. * restore grpcio requirements to the oriignal version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good, just a non-blocking question
@@ -42,7 +42,7 @@ packages=find_namespace: | |||
install_requires = | |||
opentelemetry-api == 0.13dev0 | |||
opentelemetry-sdk == 0.13dev0 | |||
grpcio == 1.30 | |||
grpcio ~= 1.27 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checking, this isn't required for the test to pass correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good 👍
Description
When running the grpc tests from the command line with
pytest instrumentation/opentelemetry-instrumentation-grpc/tests
orpython scripts/eachdist.py test
the 2nd test in theTestClientProto
test case was failing with:Looks like the problem is a leftover connection from the previous test due to the
channel
not being properly closed on test teardown. The current test then fails to connect to the test server which results inStatusCode.UNAVAILABLE
.For tox tests this was already addressed in #974 by pinning the gprc version to 1.30
Type of change
Bugfix (non-breaking change which fixes an issue)How Has This Been Tested?
Run
pytest instrumentation/opentelemetry-instrumentation-grpc/tests
without and with closing thechannel
.