Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ext/boto: Could not serialize attribute aws.region to tag when exporting via jaeger #818

Closed
ThePumpingLemma opened this issue Jun 11, 2020 · 0 comments · Fixed by #865
Closed

ext/boto: Could not serialize attribute aws.region to tag when exporting via jaeger #818

ThePumpingLemma opened this issue Jun 11, 2020 · 0 comments · Fixed by #865
Labels
bug Something isn't working good first issue Good first issue help wanted instrumentation Related to the instrumentation of third party libraries or frameworks

Comments

@ThePumpingLemma
Copy link
Contributor

Describe your environment

opentelemetry-api = "=0.9b0"
opentelemetry-ext-boto = "=0.9b0"
opentelemetry-ext-botocore = "=0.9b0"
opentelemetry-ext-dbapi = "=0.9b0"
opentelemetry-ext-jaeger = "=0.9b0"
opentelemetry-ext-psycopg2= "=0.9b0"
opentelemetry-ext-requests = "=0.9b0"
opentelemetry-instrumentation = "=0.9b0"
opentelemetry-sdk = "=0.9b0"
python = "=3.7.4"

Steps to reproduce
Install and enable ext/boto with a jaeger exporter configured. I saw the issue with SES, but I assume other calls have the same problem as well.

What is the expected behavior?
aws.region should be serialized correctly.

What is the actual behavior?
Could not serialize attribute aws.region:('us-east-1',) to tag

Additional context
Not sure how it should be serialized given jaeger doesn't appear to support list types. Probably should be coerced to a string.
@ThePumpingLemma ThePumpingLemma added the bug Something isn't working label Jun 11, 2020
@ThePumpingLemma ThePumpingLemma changed the title ext/boto: Could not serialize attribute aws.region to tag ext/boto: Could not serialize attribute aws.region to tag when exporting via jaeger Jun 11, 2020
@codeboten codeboten added good first issue Good first issue help wanted instrumentation Related to the instrumentation of third party libraries or frameworks labels Jun 11, 2020
@bitspradp bitspradp mentioned this issue Jun 27, 2020
Merged
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@Flarna @dyladan
fix: change SpanContext.traceFlags to mandatory (open-telemetry#818)
3c41f56 
* fix: change SpanContext.traceFlags to mandatory

According to spec SpanContext represents the W3C tracestate which
includes traceId, spanId and traceFlags.

As a side effect a new LinkContext types was added as links don't
have traceFlags according to spec.

* chore: review findings, rename TraceFlags.UNSAMPLED to NONE

* fix: build

* fix: tests

* fix: correct merge

Co-authored-by: Daniel Dyla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good first issue help wanted instrumentation Related to the instrumentation of third party libraries or frameworks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing the serialization of a tuple element by coercing it into a string
2 participants
@codeboten @ThePumpingLemma