Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename "ext" to "instrumentations" and "exporters" #760

Closed
toumorokoshi opened this issue May 30, 2020 · 5 comments
Closed

rename "ext" to "instrumentations" and "exporters" #760

toumorokoshi opened this issue May 30, 2020 · 5 comments
Assignees
@lzchen
Labels
release:required-for-ga To be resolved before GA release

Comments

@toumorokoshi
Copy link
Member

Now that open-telemetry/opentelemetry-specification#539 has landed, it would be great to adhere to the standard package names. I'm working with other languages as well.

For us, I think we should start by naming everything new as an "exporter" or "Instrumentation". And then a followup PR to rename.

We should do this work before 1.0 / GA, while all packages are in beta.
@toumorokoshi toumorokoshi mentioned this issue May 30, 2020
Merged
@lzchen
Copy link
Contributor

lzchen commented May 31, 2020

Good idea. I'm assuming the current Pypi packages also have to be deprecated for the new ones to replace them?

@codeboten codeboten mentioned this issue Jun 9, 2020
Closed
@codeboten codeboten mentioned this issue Jul 20, 2020
Closed
@codeboten codeboten added the release:required-for-ga To be resolved before GA release label Jul 22, 2020
This was referenced Jul 28, 2020
Merged
Merged
Merged
@lzchen lzchen mentioned this issue Aug 4, 2020
Merged
@lzchen
Copy link
Contributor

lzchen commented Aug 16, 2020

Finished package renaming with this release. Old packages on Pypi have been deprecated. As discussed, will monitor traffic of old downloads and delete old packages within the next month.

@lzchen lzchen closed this as completed Aug 16, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@Ema93sh @mayurkale22
fix: upgraded commitlint to fix warnings (open-telemetry#760)
4b764e5 
* fix: upgraded commitlint to fix warnings

* fix: update web examples to use WebTracerRegistry

closes open-telemetry#756

* Revert "fix: update web examples to use WebTracerRegistry"

This reverts commit 4dd8e67d00ebf264f59d6748e588de5b3e4d5b3b.

Co-authored-by: Mayur Kale <[email protected]>
@kaos
Copy link

kaos commented May 28, 2021

why delete old packages? that's just causing headaches, no?

@codeboten
Copy link
Contributor

Hi @kaos, we debated this for a long time across multiple SIG meetings and decided to ultimately delete the old packages as we were seeing users coming in with questions after accidentally installing packages named ext.

We were hoping this decision would reduce the confusion and maintenance burden as we were preparing to release the first stable version of OpenTelemetry python.

@kaos
Copy link

kaos commented Jun 1, 2021

Hi @codeboten
thanks for info, and that it was done under careful consideration. I do see your point, although not agreeing (but also not very well informed on the matter, so may very well be wrong)

Looking forward to a more stable product once you get the stable releases out :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lzchen lzchen

Labels
release:required-for-ga To be resolved before GA release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kaos @codeboten @toumorokoshi @lzchen