We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Right now, A resource object attached to a Span can be None:
https://github.com/open-telemetry/opentelemetry-python/blob/master/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py#L267
(also type is incorrect as it should also be a Resource object)
That means that there's two similar objects that refer to an empty resource: None, and the _EMPTY_RESOURCE global.
For simplicity I would argue that we should just always default to the _EMPTY_RESOURCE object: this avoids None checks in exporters.
We didn't use Resources in a meaningful way previously, which is why I believe this didn't come up before.
The text was updated successfully, but these errors were encountered:
chore: add missing semver type dependency (open-telemetry#702)
33098e2
Successfully merging a pull request may close this issue.
Right now, A resource object attached to a Span can be None:
https://github.com/open-telemetry/opentelemetry-python/blob/master/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py#L267
(also type is incorrect as it should also be a Resource object)
That means that there's two similar objects that refer to an empty resource: None, and the _EMPTY_RESOURCE global.
For simplicity I would argue that we should just always default to the _EMPTY_RESOURCE object: this avoids None checks in exporters.
We didn't use Resources in a meaningful way previously, which is why I believe this didn't come up before.
The text was updated successfully, but these errors were encountered: