Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add span processor #60

Closed
c24t opened this issue Jul 19, 2019 · 3 comments
Closed

Add span processor #60

c24t opened this issue Jul 19, 2019 · 3 comments
Assignees
Labels
sdk Affects the SDK package. tracing

Comments

@c24t
Copy link
Member

c24t commented Jul 19, 2019

#58 doesn't include span processor hooks. These exist in java but aren't yet included in the spec.

@c24t c24t added sdk Affects the SDK package. tracing labels Jul 19, 2019
@mauriciovasquezbernal
Copy link
Member

Could you please assign it to me? Thanks!

@a-feld
Copy link
Member

a-feld commented Aug 27, 2019

@mauriciovasquezbernal I assigned this to you 🚀
It looks like there are still some specification discussions to be had for this issue.

@mauriciovasquezbernal
Copy link
Member

I think it was solved by #115.

srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
* TraceOptions

* export TRACE_OPTIONS_SAMPLED and TRACE_OPTIONS_UNSAMPLED

* Fix review comments

* Rename TRACE_OPTIONS_SAMPLED -> SAMPLED

* Add SampleOptions enum

* Add TraceOptions as enum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdk Affects the SDK package. tracing
Projects
None yet
Development

No branches or pull requests

4 participants