Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConsoleSpanExporter export is ambiguous/incomplete #478

Closed
lizthegrey opened this issue Mar 12, 2020 · 2 comments · Fixed by #505
Closed

ConsoleSpanExporter export is ambiguous/incomplete #478

lizthegrey opened this issue Mar 12, 2020 · 2 comments · Fixed by #505
Assignees
Labels
sdk Affects the SDK package.

Comments

@lizthegrey
Copy link
Member

Is your feature request related to a problem?
Using the ConsoleSpanExporter(), we see Span(...)Span(...) with no newlines or other delimeters separating them, and attributes not reported.

Describe the solution you'd like

Span(name="fibHandler", context=SpanContext(trace_id=0xe15c7cbba84447f39c83e20cb4cd6cf7, span_id=0xbfe12c3731d17d9a, trace_state={}), kind=SpanKind.SERVER, attributes={[...]}, parent=SpanContext(trace_id=0xe15c7cbba84447f39c83e20cb4cd6cf7, span_id=0xd011389d33b829dd, trace_state={}), start_time=2020-03-12T08:56:43.718479Z, end_time=2020-03-12T08:56:43.729221Z),
Span(name="fibHandlerInternal",[...]),
Span(name="fibHandlerInternal",[...]),

Additional context
This is for clarity in the Intro to OTel workshop.

@mauriciovasquezbernal
Copy link
Member

mauriciovasquezbernal commented Mar 12, 2020

Hi @lizthegrey,

The missing line break was fixed in #455, however this is not available in any released version yet.

About the missing attributes, we are also missing links and events and their attributes, probably including them will make it very difficult to read the output.

By the way, the console exporter supports a custom formatter, in case it can help you:

formatter: typing.Callable[[Span], str] = lambda span: str(span)

@lizthegrey
Copy link
Member Author

Thanks, it does help. May I make the suggestion that at least counting number of links, attributes, and events, may be helpful even if they're not displayed in full? That way someone can tell that adding attributes has had the desired effect.

@mauriciovasquezbernal mauriciovasquezbernal self-assigned this Mar 17, 2020
@mauriciovasquezbernal mauriciovasquezbernal added the sdk Affects the SDK package. label Apr 3, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
* feat(resources): adding document load resources

* chore: removing private from jsdoc

* chore: trying to fix lint error

* chore: revert "chore: trying to fix lint error" commit 9d4439b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sdk Affects the SDK package.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants