Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move benchmark tests outside of tests directory #4029

Closed
ocelotl opened this issue Jul 6, 2024 · 0 comments · Fixed by #4033
Closed

Move benchmark tests outside of tests directory #4029

ocelotl opened this issue Jul 6, 2024 · 0 comments · Fixed by #4033
Assignees

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Jul 6, 2024

Describe your environment

OS: (e.g, Ubuntu)
Python version: (e.g., Python 3.8.10)
SDK version: (e.g., 1.25.0)
API version: (e.g., 1.25.0)

What happened?

Benchmark tests are inside tests directory.

Steps to Reproduce

Just look at tests.

Expected Result

No benchmarks in tests directory.

Actual Result

So many benchmark tests in tests directory

Additional context

So, I fixed the issue with benchmarks being run in CI at #4019 but just having them somewhere else is a much better solution that does not require ifs in our github workflows. Fix that.

Would you like to implement a fix?

None

@ocelotl ocelotl self-assigned this Jul 6, 2024
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jul 8, 2024
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant