Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary dependencies pytest, pytest-benchmark and flaky are present #4021

Closed
ocelotl opened this issue Jul 3, 2024 · 0 comments · Fixed by #4022
Closed

Unnecessary dependencies pytest, pytest-benchmark and flaky are present #4021

ocelotl opened this issue Jul 3, 2024 · 0 comments · Fixed by #4022
Assignees
@ocelotl
Labels
tests

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Jul 3, 2024

Describe your environment

OS: (e.g, Ubuntu)
Python version: (e.g., Python 3.8.10)
SDK version: (e.g., 1.25.0)
API version: (e.g., 1.25.0)

What happened?

pytest and pytest-benchmark appear in as dependencies in tox.ini and also in the test-requirements* files, the latter being unnecessary in most cases.

Steps to Reproduce

Read tox.ini

Expected Result

No unnecessary nor repeated dependencies

Actual Result

Unnecessary or repeated dependencies

Additional context

No response

Would you like to implement a fix?

None
@ocelotl ocelotl added the bug Something isn't working label Jul 3, 2024
@ocelotl ocelotl self-assigned this Jul 3, 2024
@ocelotl ocelotl changed the title Remove unnecessary dependencies pytest and pytest-benchmark Unnecessary dependencies pytest and pytest-benchmark are present Jul 3, 2024
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jul 3, 2024
@ocelotl
Remove unnecessary dependencies pytest and pytest-benchmark
07b6a95 
Fixes open-telemetry#4021
@ocelotl ocelotl added tests Skip Changelog PRs that do not require a CHANGELOG.md entry and removed bug Something isn't working Skip Changelog PRs that do not require a CHANGELOG.md entry labels Jul 3, 2024
@ocelotl ocelotl mentioned this issue Jul 3, 2024
Merged
@ocelotl ocelotl changed the title Unnecessary dependencies pytest and pytest-benchmark are present Unnecessary dependencies pytest, pytest-benchmark and flaky are present Jul 3, 2024
@ocelotl ocelotl closed this as completed in de8b9e0 Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocelotl ocelotl

Labels
tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary dependencies pytest, flaky and pytest-benchmark ocelotl/opentelemetry-python
1 participant
@ocelotl