Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RandomIdGenerator can generate invalid Span/Trace Ids #3921

Closed
sfc-gh-bdrutu opened this issue May 18, 2024 · 1 comment · Fixed by #3949
Closed

RandomIdGenerator can generate invalid Span/Trace Ids #3921

sfc-gh-bdrutu opened this issue May 18, 2024 · 1 comment · Fixed by #3949
Assignees
Labels
bug Something isn't working

Comments

@sfc-gh-bdrutu
Copy link

Describe your environment Describe any aspect of your environment relevant to the problem, including your Python version, platform, version numbers of installed dependencies, information about your cloud hosting provider, etc. If you're reporting a problem with a specific version of a library in this repo, please check whether the problem has been fixed on main.
latest

Steps to reproduce
You need to be very "lucky" to do so, but call billions of times generate_span_id until you get a ZERO value. Same issue may happen for generate_trace_id

What is the expected behavior?
Never receive an invalid Span/Trace ID from the generator (ZERO value).

What is the actual behavior?
Invalid IDs may happen.

Additional context
Add any other context about the problem here.

@sfc-gh-bdrutu sfc-gh-bdrutu added the bug Something isn't working label May 18, 2024
@zhihali
Copy link
Contributor

zhihali commented May 27, 2024

Hi, beginner here, can I try to work on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants