Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Couple span's start_time and end_time with start and end methods #361

Closed
ocelotl opened this issue Jan 9, 2020 · 0 comments · Fixed by #363
Closed

Couple span's start_time and end_time with start and end methods #361

ocelotl opened this issue Jan 9, 2020 · 0 comments · Fixed by #363
Assignees
@ocelotl
Labels
sdk Affects the SDK package.

Comments

@ocelotl
Copy link
Contributor

ocelotl commented Jan 9, 2020

This started as a valid point raised by @toumorokoshi while discussing #358. The SDK Span start_time and end_time can be set by the user manually. This can be a problem because the same attributes are used to determine if the span has started or ended.

Protect these attributes from manual user setting. Raise a warning to the user when an attempt is made to do so.
@ocelotl ocelotl added the sdk Affects the SDK package. label Jan 9, 2020
@ocelotl ocelotl self-assigned this Jan 9, 2020
@ocelotl ocelotl changed the title Couple span's start_time and end_time with start and end methods Couple span's start_time and end_time with start and end methods Jan 9, 2020
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jan 10, 2020
@ocelotl
Protect start_time and end_time from bein set manually by the user
cbdfc3d 
Fixes open-telemetry#361
@ocelotl ocelotl mentioned this issue Jan 10, 2020
Merged
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jan 10, 2020
@ocelotl
Protect start_time and end_time from bein set manually by the user
9d986d4 
Fixes open-telemetry#361
@c24t c24t closed this as completed in #363 Jan 13, 2020
c24t pushed a commit that referenced this issue Jan 13, 2020
@ocelotl @c24t
Protect start_time and end_time from being set manually by the user (#…
f0ba817 
…363)

Fixes #361
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@danielkhan
chore: Docs wording and example for basic-tracer (open-telemetry#361)
28ca1f6 
* docs: docs and example for basic-tracer

* chore: rename to node-basic-tracer for clarity

* chore: rename again to basic-tracer-node

* docs: update docs and example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocelotl ocelotl

Labels
sdk Affects the SDK package.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Protect start_time and end_time from being set manually by the user ocelotl/opentelemetry-python
1 participant
@ocelotl