-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enforcement of AttributeValues for trace events #347
Comments
I'll take this one. Can this be assigned to me to avoid duplicating work? |
Done! Thanks, @jakemalachowski 👍 |
With #348 merged I think that this issue can be closed! |
@dgzlopes not actually, #348 was about span attributes, this one is about attributes in Event: opentelemetry-python/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py Lines 268 to 280 in a7535a1
|
Closed by #678 |
* feat(plugin-http): handle client errors closes open-telemetry#347 Signed-off-by: Olivier Albertini <[email protected]> * fix: handling error in line with spec Signed-off-by: Olivier Albertini <[email protected]>
Right now, AttributeValues in span tags are supposed to be one of (int, bool, float), but we do no enforcement of that value when added.
This then requires error handling to be put into the exporters themselves, which will become fairly redundant: https://github.com/open-telemetry/opentelemetry-python/pull/320/files/93331ff73905ab0dad11110bdac45737098c2d26#r360226796
It would be great if we could enforce the types of attributes when added instead.
The text was updated successfully, but these errors were encountered: