-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTLP exporters should emit standard user agent string #2958
Comments
Adding user agent string to OTLP HTTP exporter. As part of the change, I refactored the content-type header as well. Part of open-telemetry#2958
* `exporter-otlp-proto-http`: add user agent string Adding user agent string to OTLP HTTP exporter. As part of the change, I refactored the content-type header as well. Part of #2958 * update changelog * fix linting, fix link Co-authored-by: Srikanth Chekuri <[email protected]>
Hi! I would like to take this as part of my outreachy contribution? |
@pridhi-arora The last mentioned pull request only added the user agent header for the HTTP exporter https://github.com/open-telemetry/opentelemetry-python/tree/main/exporter/opentelemetry-exporter-otlp-proto-http but the same should also be done for the gRPC exporter https://github.com/open-telemetry/opentelemetry-python/tree/main/exporter/opentelemetry-exporter-otlp-proto-grpc. More specifically this |
Thanks, @srikanthccv. I will have something by tomorrow. |
@srikanthccv
From what I got to know by the way we send data in headers for grpc is
Keeping this format in mind. Does the following sound good?
|
|
@srikanthccv How do I update the header in _log_exporter/init.py |
If you notice, it calls |
@srikanthccv I have tried something here. Can you please take a look? |
As per the following change in the specification (1.14 releasing Oct 4):
See https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md#user-agent
The text was updated successfully, but these errors were encountered: