Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we be handling these exceptions similarly in how we handle shutdown? #2665

Closed
aabmass opened this issue May 6, 2022 · 2 comments · Fixed by #2671
Closed

Should we be handling these exceptions similarly in how we handle shutdown? #2665

aabmass opened this issue May 6, 2022 · 2 comments · Fixed by #2671
Assignees
@ocelotl
Labels
metrics sdk Affects the SDK package.

Comments

@aabmass
Copy link
Member

aabmass commented May 6, 2022 •
edited
Loading

Should we be handling these exceptions similarly in how we handle shutdown?

Originally posted by @lzchen in #2653 (comment)

Context:

The MeterProvider.force_flush() should probably flush all metric readers and not fail on the first one.
@aabmass aabmass mentioned this issue May 6, 2022
Merged
8 tasks
@aabmass aabmass added sdk Affects the SDK package. metrics labels May 6, 2022
@lzchen
Copy link
Contributor

lzchen commented May 6, 2022 •
edited
Loading

+1 to not failing on the first one. Following this we can log the error after.

@ocelotl ocelotl self-assigned this May 6, 2022
@ocelotl
Copy link
Contributor

ocelotl commented May 6, 2022

I am ok, assigning to myself.

ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue May 7, 2022
@ocelotl
Check exceptions in force_flush too
684e4c8 
Fixes open-telemetry#2665
@ocelotl ocelotl mentioned this issue May 7, 2022
Merged
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue May 7, 2022
@ocelotl
Check exceptions in force_flush too
2793213 
Fixes open-telemetry#2665
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ocelotl ocelotl

Labels
metrics sdk Affects the SDK package.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check exceptions in force_flush too ocelotl/opentelemetry-python
3 participants
@aabmass @ocelotl @lzchen