-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add *args, **kwargs
to user implementable interfaces
#2650
Comments
Adding this to metric components will probably be blocking for the release. Should only be a few (exporter, metricreader). |
ocelotl
changed the title
I think potentially we should try to add
Add Apr 29, 2022
*args, **kwargs
or config objects to any user implementable interfaces going forward to avoid this kind of issue.*args, **kwargs
to user implementable interfaces
ocelotl
added a commit
to ocelotl/opentelemetry-python
that referenced
this issue
May 1, 2022
ocelotl
added a commit
to ocelotl/opentelemetry-python
that referenced
this issue
May 2, 2022
ocelotl
added a commit
to ocelotl/opentelemetry-python
that referenced
this issue
May 2, 2022
Just want to call out one alternative: @dataclass(frozen=True)
class ExportConfig:
pass
# ...
class MetricExporter(ABC):
def export(self, metrics: Sequence[Metric], export_config: ExportConfig = ExportConfig()):
pass |
ocelotl
added a commit
that referenced
this issue
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think potentially we should try to add
*args, **kwargs
or config objects to any user implementable interfaces going forward to avoid this kind of issue.Originally posted by @aabmass in #2402 (comment)
The text was updated successfully, but these errors were encountered: