Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTLP HTTP Exporter should append v1/{signal} to the endpoint URL when non-per-signal env var is used #2443

Closed
reese-lee opened this issue Feb 5, 2022 · 4 comments · Fixed by #2493
Assignees
Labels
bug Something isn't working

Comments

@reese-lee
Copy link
Member

Per the spec re: Endpoint URLs for OTLP/HTTP, when the non-per-signal endpoint env var (OTEL_EXPORTER_OTLP_ENDPOINT) is set, the exporter must construct per-signal URLs (either v1/traces or v1/metrics).

Currently, the exporter does not do this; v1/traces must be manually added to the end point when setting only OTEL_EXPORTER_OTLP_ENDPOINT. Not doing so produces a 404 error when attempting to export spans.

@ocelotl ocelotl added bug Something isn't working and removed feature-request labels Feb 9, 2022
@flyinprogrammer
Copy link

😅 i thought i was going crazy, i can submit a PR to make this bit smarter, it might be considered a breaking change though 😢 so idk what all will be involved in merging this.

@reese-lee
Copy link
Member Author

@flyinprogrammer I wanted to see if you plan on submitting a PR for this? I'd like to take a stab at it with my colleague otherwise. :)

@flyinprogrammer
Copy link

flyinprogrammer commented Feb 25, 2022 via email

@reese-lee
Copy link
Member Author

Thank you for the update! @TylerHelmuth and I will work on a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants