Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing exporters from MeterProvider __init__ parameters #2316

Closed
lzchen opened this issue Dec 9, 2021 · 1 comment · Fixed by #2359
Closed

Consider removing exporters from MeterProvider __init__ parameters #2316

lzchen opened this issue Dec 9, 2021 · 1 comment · Fixed by #2359
Labels
metrics sdk Affects the SDK package.

Comments

@lzchen
Copy link
Contributor

lzchen commented Dec 9, 2021

From this comment.

@lzchen lzchen added sdk Affects the SDK package. metrics labels Dec 9, 2021
@ocelotl ocelotl changed the title Consider removing exporters from MetricProvider Consider removing exporters from MeterProvider __init__ parameters Dec 15, 2021
@codeboten
Copy link
Contributor

This would allow us to move Metric and MetricData into _metrics/__init__.py as mentioned in #2323, as it stands today, it causes a circular import.

ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jan 10, 2022
ocelotl added a commit to ocelotl/opentelemetry-python that referenced this issue Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
metrics sdk Affects the SDK package.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants