-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support OTEL_ATTRIBUTE_COUNT_LIMIT
#2055
Comments
Perhaps this should be understood as: Even if model specific limit has a default value, if the model specific value is not provided, but |
That is how I think it should work as well but spec says if the default is provided then it should use the default instead of the global (OTEL_ATTRIBUTE_COUNT_LIMIT). From the spec:
|
I created this issue to clarify or update spec: open-telemetry/opentelemetry-specification#1878 |
* Add support for OTEL_ATTRIBUTE_COUNT_LIMIT Fixes #2055 Fixes #2111 * Update opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py Co-authored-by: Srikanth Chekuri <[email protected]> Co-authored-by: Srikanth Chekuri <[email protected]>
Spec mentions global
OTEL_ATTRIBUTE_COUNT_LIMIT
env var. According tot he spec, any model specific attribute count limit such as span, event or link attribute count limit should fallback to this if the model specific limit is not specified by the user.The text was updated successfully, but these errors were encountered: