Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zipkin exporter must map status #1111

Closed
codeboten opened this issue Sep 14, 2020 · 2 comments · Fixed by #1124
Closed

Zipkin exporter must map status #1111

codeboten opened this issue Sep 14, 2020 · 2 comments · Fixed by #1124
Assignees
@wilguo
Labels
exporters good first issue Good first issue help wanted

Comments

@codeboten
Copy link
Contributor

As per spec: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk_exporters/zipkin.md#status
@wilguo
Copy link
Contributor

wilguo commented Sep 15, 2020

Hi @codeboten, just joined @alolita team on AWS. Can I take this on as my first issue?

@codeboten
Copy link
Contributor Author

Sounds great!

wilguo added a commit to open-o11y/opentelemetry-python that referenced this issue Sep 16, 2020
@wilguo
[Issue open-telemetry#1111] Add span status to tags for Zipkin exporter
53199dc
wilguo added a commit to open-o11y/opentelemetry-python that referenced this issue Sep 16, 2020
@wilguo
[Issue open-telemetry#1111] Add status code to unit test for Zipkin e…
2c05bc0 
…xporter
This was referenced Sep 16, 2020
Closed
Merged
wilguo added a commit to open-o11y/opentelemetry-python that referenced this issue Sep 16, 2020
@wilguo
[Issue open-telemetry#1111] Fix lint errors
db9673f
wilguo added a commit to open-o11y/opentelemetry-python that referenced this issue Sep 17, 2020
@wilguo
[Issue open-telemetry#1111] Update changelog for Zipkin exporter
9a31db1
wilguo added a commit to open-o11y/opentelemetry-python that referenced this issue Sep 17, 2020
@wilguo
[Issue open-telemetry#1111] Add test to test status code change and s…
9a7ec13 
…tatus description for Zipkin exporter
wilguo added a commit to open-o11y/opentelemetry-python that referenced this issue Sep 18, 2020
@wilguo
[Issue open-telemetry#1111] Changed status to use otel instead of ot
96d07f2
codeboten pushed a commit that referenced this issue Sep 18, 2020
@wilguo
exporter/zipkin: Add status to the tags for the Zipkin Exporter (#1124)
e275d70 
* [Issue #1111] Add span status to tags for Zipkin exporter
alertedsnake pushed a commit to alertedsnake/opentelemetry-python that referenced this issue Sep 25, 2020
@wilguo
exporter/zipkin: Add status to the tags for the Zipkin Exporter (open…
f1199ff 
…-telemetry#1124)

* [Issue open-telemetry#1111] Add span status to tags for Zipkin exporter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilguo wilguo

Labels
exporters good first issue Good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add status to the tags for the Zipkin Exporter open-o11y/opentelemetry-python
2 participants
@codeboten @wilguo