Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

botocore instrumentation failure blocking the build #1088

Closed
codeboten opened this issue Sep 9, 2020 · 0 comments · Fixed by #1100
Closed

botocore instrumentation failure blocking the build #1088

codeboten opened this issue Sep 9, 2020 · 0 comments · Fixed by #1100
Assignees
@codeboten
Labels
bug Something isn't working build & infra Issues related to build & infrastructure.

Comments

@codeboten
Copy link
Contributor

As seen here: https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-python/905/workflows/4c29ce5d-e4a4-434b-9a75-91af1eae8e73/jobs/19330

As noted by @lzchen:

Looks like a new version of botocore is causing build failures.
@codeboten codeboten added bug Something isn't working build & infra Issues related to build & infrastructure. labels Sep 9, 2020
@lzchen lzchen mentioned this issue Sep 9, 2020
Merged
@codeboten codeboten self-assigned this Sep 11, 2020
codeboten pushed a commit to codeboten/opentelemetry-python that referenced this issue Sep 11, 2020
instrumentation/botocore: fix failing test
84e6487 
The failing test was introduced I believe by a change in behaviour noted in this issue: getmoto/moto#3292. The solution is to set a region in the create_bucket call.

Fixes open-telemetry#1088
@codeboten codeboten mentioned this issue Sep 11, 2020
Merged
4 tasks
codeboten pushed a commit that referenced this issue Sep 14, 2020
instrumentation/botocore: fix failing test (#1100)
23cf584 
The failing test was introduced I believe by a change in behaviour noted in this issue: getmoto/moto#3292. The solution is to set a region in the create_bucket call.

Fixes #1088
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
@mayurkale22
chore: remove unused test_utils (open-telemetry#1088)
2391385
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeboten codeboten

Labels
bug Something isn't working build & infra Issues related to build & infrastructure.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

instrumentation/botocore: fix failing test codeboten/opentelemetry-python
1 participant
@codeboten