Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attributes return from sampling results should be immutable #1065

Closed
lzchen opened this issue Sep 2, 2020 · 0 comments
Closed

Attributes return from sampling results should be immutable #1065

lzchen opened this issue Sep 2, 2020 · 0 comments
Assignees
@lzchen
Labels
good first issue Good first issue release:required-for-ga To be resolved before GA release sdk Affects the SDK package.

Comments

@lzchen
Copy link
Contributor

lzchen commented Sep 2, 2020

https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk.md#sampler

A set of span Attributes that will also be added to the Span. The returned object must be immutable (multiple calls may return different immutable objects).
@lzchen lzchen added good first issue Good first issue sdk Affects the SDK package. release:required-for-ga To be resolved before GA release labels Sep 2, 2020
@lzchen lzchen self-assigned this Sep 2, 2020
@lzchen lzchen mentioned this issue Sep 2, 2020
Merged
@lzchen lzchen closed this as completed Sep 3, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this issue Nov 1, 2020
style: format README (open-telemetry#1065)
4056f36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lzchen lzchen

Labels
good first issue Good first issue release:required-for-ga To be resolved before GA release sdk Affects the SDK package.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lzchen