Skip to content

Commit

Permalink
Add fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
ocelotl committed Aug 17, 2020
1 parent 338cc53 commit f9df1e4
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 4 deletions.
1 change: 1 addition & 0 deletions .pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ disable=missing-docstring,
too-few-public-methods, # Might be good to re-enable this later.
too-many-instance-attributes,
too-many-arguments,
duplicate-code,
ungrouped-imports, # Leave this up to isort
wrong-import-order, # Leave this up to isort
bad-continuation, # Leave this up to black
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -189,3 +189,6 @@ def _export(self, data):
return self.result.FAILURE

return self._result.FAILURE

def shutdown(self):
pass
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@
"""OTLP Metrics Exporter"""

import logging
from typing import Sequence

# pylint: disable=duplicate-code
from opentelemetry.exporter.otlp.exporter import (
OTLPExporterMixin,
_get_resource_data,
Expand All @@ -39,8 +41,9 @@
MetricDescriptor,
ResourceMetrics,
)
from opentelemetry.sdk.metrics import Counter
from opentelemetry.sdk.metrics import Metric as SDKMetric
from opentelemetry.sdk.metrics import (
Counter,
SumObserver,
UpDownCounter,
UpDownSumObserver,
Expand Down Expand Up @@ -189,3 +192,7 @@ def _translate_data(self, data):
"metrics",
)
)

def export(self, metrics: Sequence[SDKMetric]) -> MetricsExportResult:
# pylint: disable=arguments-differ
return self._export(metrics)
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,3 @@ def _translate_data(self, data) -> ExportTraceServiceRequest:

def export(self, spans: Sequence[SDKSpan]) -> SpanExportResult:
return self._export(spans)

def shutdown(self):
pass

0 comments on commit f9df1e4

Please sign in to comment.