ext/jaeger: Fixing the serialization of a tuple element by coercing i…

…t into a string (#865) Could not serialize attribute aws.region to tag when exporting via jaeger Serialize tuple type values by coercing them into a string, since Jaeger does not support tuple types.
open-telemetry · Jul 13, 2020 · e31c4bb · e31c4bb
1 parent b085f37
commit e31c4bb
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 0 deletions.
diff --git a/ext/opentelemetry-ext-jaeger/CHANGELOG.md b/ext/opentelemetry-ext-jaeger/CHANGELOG.md
@@ -8,6 +8,10 @@ Released 2020-05-27
 
 - Transform resource to tags when exporting
   ([#645](https://github.com/open-telemetry/opentelemetry-python/pull/645))
+- ext/boto: Could not serialize attribute aws.region to tag when exporting via jaeger
+  Serialize tuple type values by coercing them into a string, since Jaeger does not
+  support tuple types.
+  ([#865](https://github.com/open-telemetry/opentelemetry-python/pull/865))
 
 ## 0.6b0
 

diff --git a/ext/opentelemetry-ext-jaeger/src/opentelemetry/ext/jaeger/__init__.py b/ext/opentelemetry-ext-jaeger/src/opentelemetry/ext/jaeger/__init__.py
@@ -314,6 +314,8 @@ def _convert_attribute_to_tag(key, attr):
         return jaeger.Tag(key=key, vLong=attr, vType=jaeger.TagType.LONG)
     if isinstance(attr, float):
         return jaeger.Tag(key=key, vDouble=attr, vType=jaeger.TagType.DOUBLE)
+    if isinstance(attr, tuple):
+        return jaeger.Tag(key=key, vStr=str(attr), vType=jaeger.TagType.STRING)
     logger.warning("Could not serialize attribute %s:%r to tag", key, attr)
     return None
 

diff --git a/ext/opentelemetry-ext-jaeger/tests/test_jaeger_exporter.py b/ext/opentelemetry-ext-jaeger/tests/test_jaeger_exporter.py
@@ -200,6 +200,7 @@ def test_translate_to_jaeger(self):
         otel_spans[0].set_attribute("key_bool", False)
         otel_spans[0].set_attribute("key_string", "hello_world")
         otel_spans[0].set_attribute("key_float", 111.22)
+        otel_spans[0].set_attribute("key_tuple", ("tuple_element",))
         otel_spans[0].resource = Resource(
             labels={"key_resource": "some_resource"}
         )
@@ -241,6 +242,11 @@ def test_translate_to_jaeger(self):
                         vType=jaeger.TagType.DOUBLE,
                         vDouble=111.22,
                     ),
+                    jaeger.Tag(
+                        key="key_tuple",
+                        vType=jaeger.TagType.STRING,
+                        vStr="('tuple_element',)",
+                    ),
                     jaeger.Tag(
                         key="key_resource",
                         vType=jaeger.TagType.STRING,