Remove _with_limits() from tracer

open-telemetry · May 24, 2021 · dddf654 · dddf654
1 parent 9a22c15
commit dddf654
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py
@@ -934,10 +934,6 @@ def __init__(
         self.instrumentation_info = instrumentation_info
         self._limits = None
 
-    def _with_limits(self, limits: _Limits) -> "Tracer":
-        self._limits = limits
-        return self
-
     @contextmanager
     def start_as_current_span(
         self,
@@ -1085,15 +1081,17 @@ def get_tracer(
         if not instrumenting_module_name:  # Reject empty strings too.
             instrumenting_module_name = ""
             logger.error("get_tracer called with missing module name.")
-        return Tracer(
+        tracer = Tracer(
             self.sampler,
             self.resource,
             self._active_span_processor,
             self.id_generator,
             InstrumentationInfo(
                 instrumenting_module_name, instrumenting_library_version
             ),
-        )._with_limits(self._limits)
+        )
+        tracer._limits = self._limits
+        return tracer
 
     def add_span_processor(self, span_processor: SpanProcessor) -> None:
         """Registers a new :class:`SpanProcessor` for this `TracerProvider`.