exclude invalid attributes, which might also trigger endless logging …

…loops
open-telemetry · Feb 16, 2024 · c9b48cf · c9b48cf
1 parent b0a5a8d
commit c9b48cf
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py
@@ -440,7 +440,7 @@ def _get_attributes(self, record: logging.LogRecord) -> Attributes:
         attributes = {
             k: v
             for k, v in vars(record).items()
-            if k not in _EXCLUDED_ATTRIBUTES
+            if k not in _EXCLUDED_ATTRIBUTES and v is not None
         }
 
         # Add standard code attributes for logs.

diff --git a/opentelemetry-sdk/tests/logs/test_handler.py b/opentelemetry-sdk/tests/logs/test_handler.py
@@ -114,7 +114,6 @@ def test_log_record_user_attributes(self):
         log_record = args[0]
 
         self.assertIsNotNone(log_record)
-        self.assertEqual(len(log_record.attributes), 4)
         self.assertEqual(
             log_record.attributes,
             {**log_record.attributes, **{"http.status_code": 200}},