fix: b3 propagation needs to check if parent is SpanContext (#621)

open-telemetry · Apr 30, 2020 · c772bb7 · c772bb7
1 parent d01d779
commit c772bb7
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/trace/propagation/b3_format.py b/opentelemetry-sdk/src/opentelemetry/sdk/trace/propagation/b3_format.py
@@ -137,7 +137,7 @@ def inject(
             set_in_carrier(
                 carrier,
                 self.PARENT_SPAN_ID_KEY,
-                format_span_id(span.parent.context.span_id),
+                format_span_id(span.parent.span_id),
             )
         set_in_carrier(carrier, self.SAMPLED_KEY, "1" if sampled else "0")
 

diff --git a/opentelemetry-sdk/tests/trace/propagation/test_b3_format.py b/opentelemetry-sdk/tests/trace/propagation/test_b3_format.py
@@ -45,7 +45,7 @@ def get_child_parent_new_carrier(old_carrier):
             trace_flags=parent_context.trace_flags,
             trace_state=parent_context.trace_state,
         ),
-        parent=parent,
+        parent=parent.get_context(),
     )
 
     new_carrier = {}