Skip to content

Commit

Permalink
Use current logger instead of global (#351)
Browse files Browse the repository at this point in the history
All loggers should be local to the module, rather than use the global.
  • Loading branch information
hectorhdzg authored and toumorokoshi committed Jan 3, 2020
1 parent 4458698 commit b72cab5
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -137,11 +137,11 @@ def on_start(self, span: Span) -> None:

def on_end(self, span: Span) -> None:
if self.done:
logging.warning("Already shutdown, dropping span.")
logger.warning("Already shutdown, dropping span.")
return
if len(self.queue) == self.max_queue_size:
if not self._spans_dropped:
logging.warning("Queue is full, likely spans will be dropped.")
logger.warning("Queue is full, likely spans will be dropped.")
self._spans_dropped = True

self.queue.appendleft(span)
Expand Down

0 comments on commit b72cab5

Please sign in to comment.