Address @Oberon00's comments

open-telemetry · Oct 21, 2019 · b653f3e · b653f3e
1 parent b7f1324
commit b653f3e
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/opentelemetry-api/src/opentelemetry/trace/sampling.py b/opentelemetry-api/src/opentelemetry/trace/sampling.py
@@ -56,7 +56,7 @@ def should_sample(
         trace_id: int,
         span_id: int,
         name: str,
-        links: Optional[Sequence["Link"]] = None,
+        links: Sequence["Link"] = (),
     ) -> "Decision":
         pass
 
@@ -73,7 +73,7 @@ def should_sample(
         trace_id: int,
         span_id: int,
         name: str,
-        links: Optional[Sequence["Link"]] = None,
+        links: Sequence["Link"] = (),
     ) -> "Decision":
         return self._decision
 
@@ -110,12 +110,12 @@ def should_sample(
         trace_id: int,
         span_id: int,
         name: str,
-        links: Optional[Sequence["Link"]] = None,
+        links: Sequence["Link"] = (),
     ) -> "Decision":
         if parent_context is not None:
             return Decision(parent_context.trace_options.sampled)
 
-        return Decision(trace_id & self.CHECK_BYTES < self.bound, {})
+        return Decision(trace_id & self.CHECK_BYTES < self.bound)
 
 
 # Samplers that ignore the parent sampling decision and never/always sample.