Skip to content

Commit

Permalink
sdk: skip test_batch_span_processor_scheduled_delay on pypy / windows
Browse files Browse the repository at this point in the history
It happened that tests failed because the delay was fired some
microseconds earlier:

>       self.assertGreaterEqual((export_time - start_time) * 1e3, 500)
E       AssertionError: 499.9737739562988 not greater than or equal to 500

We should probably revise all these skip on Windows Pypy once we have a
Python 3.9 baseline and Pypy >= 7.3.12.

Fix #3911
  • Loading branch information
xrmx committed Jun 3, 2024
1 parent 4febd33 commit 8b2cd41
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions opentelemetry-sdk/tests/trace/export/test_export.py
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,10 @@ def _target():

span_processor.shutdown()

@mark.skipif(
python_implementation() == "PyPy" and system() == "Windows",
reason="This test randomly fails in Windows with PyPy",
)
def test_batch_span_processor_scheduled_delay(self):
"""Test that spans are exported each schedule_delay_millis"""
spans_names_list = []
Expand Down

0 comments on commit 8b2cd41

Please sign in to comment.