Make exceptions private

open-telemetry · Apr 13, 2022 · 88f3a06 · 88f3a06
1 parent e48f12f
commit 88f3a06
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/...-api/src/opentelemetry/util/exceptions.py → ...api/src/opentelemetry/util/_exceptions.py b/...-api/src/opentelemetry/util/exceptions.py → ...api/src/opentelemetry/util/_exceptions.py
@@ -15,7 +15,7 @@
 from typing import List
 
 
-class Failure(Exception):
+class _Failure(Exception):
     "Exception raised when a function fails"
 
     def __init__(self, method: str, exceptions: List[Exception]):
@@ -35,5 +35,5 @@ def __str__(self) -> str:
         )
 
 
-class Timeout(Exception):
+class _Timeout(Exception):
     "Exception raised when a function times out"
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/_metrics/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/_metrics/__init__.py
@@ -50,7 +50,7 @@
 from opentelemetry.sdk.resources import Resource
 from opentelemetry.sdk.util.instrumentation import InstrumentationInfo
 from opentelemetry.util._once import Once
-from opentelemetry.util.exceptions import Failure
+from opentelemetry.util.exceptions import _Failure
 
 _logger = getLogger(__name__)
 
@@ -334,7 +334,7 @@ def _shutdown():
             self._atexit_handler = None
 
         if metric_reader_errors:
-            raise Failure("MeterProvider.shutdown", metric_reader_errors)
+            raise _Failure("MeterProvider.shutdown", metric_reader_errors)
 
     def get_meter(
         self,

diff --git a/opentelemetry-sdk/tests/metrics/test_metrics.py b/opentelemetry-sdk/tests/metrics/test_metrics.py
@@ -32,7 +32,7 @@
 from opentelemetry.sdk._metrics.point import AggregationTemporality
 from opentelemetry.sdk.resources import Resource
 from opentelemetry.test.concurrency_test import ConcurrencyTestBase, MockFunc
-from opentelemetry.util.exceptions import Failure
+from opentelemetry.util.exceptions import _Failure
 
 
 class DummyMetricReader(MetricReader):
@@ -162,12 +162,12 @@ def test_shutdown(self):
             metric_readers=[mock_metric_reader_0, mock_metric_reader_1]
         )
 
-        with self.assertRaises(Failure) as error:
+        with self.assertRaises(_Failure) as error:
             meter_provider.shutdown()
 
         error = error.exception
 
-        self.assertIsInstance(error, Failure)
+        self.assertIsInstance(error, _Failure)
         self.assertEqual(
             str(error),
             (