fix: improve if statements and hardcode exception_type in tests

open-telemetry · Apr 8, 2024 · 884d8ba · 884d8ba
1 parent a06a30c
commit 884d8ba
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 11 deletions.
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py
@@ -995,18 +995,11 @@ def record_exception(
                 type(exception), value=exception, tb=exception.__traceback__
             )
         )
-        module = (
-            exception.__module__
-            if type(exception).__module__ != "builtins"
-            else ""
-        )
+        module = type(exception).__module__
         qualname = type(exception).__qualname__
-        exc_type = (
-            f"{module}.{qualname}"
-            if module else qualname
-        )
+        exception_type = f"{module}.{qualname}" if module and module != "builtins" else qualname
         _attributes: MutableMapping[str, types.AttributeValue] = {
-            "exception.type": exc_type,
+            "exception.type": exception_type,
             "exception.message": str(exception),
             "exception.stacktrace": stacktrace,
             "exception.escaped": str(escaped),

diff --git a/opentelemetry-sdk/tests/trace/test_trace.py b/opentelemetry-sdk/tests/trace/test_trace.py
@@ -1151,7 +1151,7 @@ def error_status_test(context):
     def test_record_exception_fqn(self):
         span = trace._Span("name", mock.Mock(spec=trace_api.SpanContext))
         exception = DummyError("error")
-        exception_type = f"{exception.__module__}.{type(exception).__qualname__}"
+        exception_type = "tests.trace.test_trace.DummyError"
         span.record_exception(exception)
         exception_event = span.events[0]
         self.assertEqual("exception", exception_event.name)