Defensive copy for BoundedList deque iter

open-telemetry · Jul 23, 2019 · 7836995 · 7836995
1 parent e9e59ac
commit 7836995
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py b/opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py
@@ -59,7 +59,8 @@ def __len__(self):
         return len(self._dq)
 
     def __iter__(self):
-        return iter(self._dq)
+        with self._lock:
+            return iter(self._dq.copy())
 
     def append(self, item):
         with self._lock: