Fixed debug field usage in zipkin exporter

Zipkin spec expects the debug field to be a boolean, not an integer. OpenTelemetry collector rejects spans exported by the Python Zipkin exporter with the following error message: ``` Traces cannot be uploaded; status code: 400, message json: cannot unmarshal number into Go struct field .debug of type bool ``` Zipkin data model confirm that the field should be a boolean here: https://zipkin.io/zipkin-api/
open-telemetry · Apr 3, 2020 · 464cfa2 · 464cfa2
1 parent aea6530
commit 464cfa2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/ext/opentelemetry-ext-zipkin/src/opentelemetry/ext/zipkin/__init__.py b/ext/opentelemetry-ext-zipkin/src/opentelemetry/ext/zipkin/__init__.py
@@ -180,7 +180,7 @@ def _translate_to_zipkin(self, spans: Sequence[Span]):
             }
 
             if context.trace_flags.sampled:
-                zipkin_span["debug"] = 1
+                zipkin_span["debug"] = True
 
             if isinstance(span.parent, Span):
                 zipkin_span["parentId"] = format(

diff --git a/ext/opentelemetry-ext-zipkin/tests/test_zipkin_exporter.py b/ext/opentelemetry-ext-zipkin/tests/test_zipkin_exporter.py
@@ -197,7 +197,7 @@ def test_export(self):
                         "value": "event0",
                     }
                 ],
-                "debug": 1,
+                "debug": True,
                 "parentId": format(parent_id, "x"),
             },
             {