Skip to content

Commit

Permalink
Add minor fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
ocelotl committed Dec 20, 2019
1 parent 6ffa86c commit 2396db1
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 4 deletions.
4 changes: 2 additions & 2 deletions examples/opentracing/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ package](https://github.com/open-telemetry/opentelemetry-python/tree/master/ext/
to interact with libraries instrumented with
[`opentracing-python`](https://github.com/opentracing/opentracing-python).

The included `rediscache` library creates spans via the OpenTelemetry Redis
The included `rediscache` library creates spans via the OpenTracing Redis
integration,
[`redis_opentracing`](https://github.com/opentracing-contrib/python-redis).
Spans are exported via the Jaeger exporter, which is attached to the
Expand Down Expand Up @@ -66,7 +66,7 @@ Open the Jaeger UI in your browser at
Each `main.py` run should generate a trace, and each trace should include
multiple spans that represent calls to Redis.

<p align="center"><img src="images/jaeger-trace-full.png?raw=true"/></p>
<p align="center"><img src="./images/jaeger-trace-full.png?raw=true"/></p>

Note that tags and logs (OpenTracing) and attributes and events (OpenTelemetry)
from both tracing systems appear in the exported trace.
Expand Down
2 changes: 1 addition & 1 deletion examples/opentracing/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def fib(n):
if n < 0:
raise ValueError
if n == 0 or n == 1:
return 1
return n
return fib(n - 1) + fib(n - 2)


Expand Down
2 changes: 2 additions & 0 deletions examples/opentracing/requirements.txt
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
opentelemetry-api
opentelemetry-sdk
opentelemetry-ext-jaeger
opentelemetry-opentracing-shim
redis
redis_opentracing
1 change: 0 additions & 1 deletion test

This file was deleted.

0 comments on commit 2396db1

Please sign in to comment.