code changes to resolve conditional server span creation for WSGI and adding 'attributes' parameter to util function #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
reviewed
Feb 5, 2022
...tation/opentelemetry-instrumentation-wsgi/src/opentelemetry/instrumentation/wsgi/__init__.py
Show resolved
Hide resolved
sanketmehta28
changed the title
…ameter. Also calling _start_internal_or_server_span() in WSGI instrumentation
owais
approved these changes
Feb 7, 2022
|
@owais Can you please run the benchmark job again as this is flaky issue? |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tps://github.com//issues/454)
Description
This PR contains code changes for conditional server span creation for WSGI framework in case of another framework is present and it has already created SERVER span. In that case WSGI instrumentation will create a span of kind INTERNAL and make it a child of the SERVER span mentioned above.
Also I have added 'attributes' parameter to a util function _start_internal_or_server_span() util function to make it more compatible with multiple frameworks
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.