Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Move exporter prometheus" #88

Merged
merged 9 commits into from
Oct 23, 2020

Conversation

codeboten
Copy link
Contributor

Reverts #81

@codeboten codeboten requested a review from a team October 23, 2020 03:28
@codeboten codeboten merged commit 64c712f into master Oct 23, 2020
@codeboten codeboten deleted the revert-81-move-exporter-prometheus branch November 24, 2020 17:05
@alolita
Copy link
Member

alolita commented Dec 7, 2021

@codeboten My team had added the PRW exporter initially to the Python SDK (see https://aws.amazon.com/blogs/opensource/building-a-prometheus-remote-write-exporter-for-the-opentelemetry-python-sdk/).

Any reason why the code was removed from the project? Where is the code now?

@codeboten
Copy link
Contributor Author

@alolita the code for the prometheus and prometheus remote write exporters was moved to the metrics branch for the python and python contrib repos:

https://github.com/open-telemetry/opentelemetry-python/tree/metrics/exporter/opentelemetry-exporter-prometheus
https://github.com/open-telemetry/opentelemetry-python-contrib/tree/metrics/exporter/opentelemetry-exporter-prometheus-remote-write

As these relied on the previous implementation of the metrics SDK, they were moved at the same time as that code to allow the tracing signal to be released as 1.0. See this issue open-telemetry/opentelemetry-python#2291 for a discussion of bringing the code back into main now that the metrics API/SDK are being merged into that branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants