(instrumentation-sqlite3): trace connections made with dbapi2.connect
#873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srikanthccv
changed the title
wrap_connect method for sqlite3dbapi2.connect
ocelotl
approved these changes
Jan 26, 2022
sanketmehta28
pushed a commit
to sanketmehta28/opentelemetry-python-contrib
that referenced
this pull request
Jan 26, 2022
…t` (open-telemetry#873) * Change wrap_connect method * Wrap both connect defs * Add tests * Add CHANGELOG entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Django basic app auto instrumentation with sqlite3 as a backend didn't produce the db spans. Digging further I realised it uses the
dbapi2.connect(which is same assqlite3.connect) for historical reasons. This updates to instrument both.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
tox -e test-instruementation-sqlite3Checklist:
See contributing.md for styleguide, changelog guidelines, and more.