Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove special support for celery from sitecustomize #799

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

owais
Copy link
Contributor

@owais owais commented Nov 10, 2021

Description

This is not required anymore after merging open-telemetry/opentelemetry-python#2242

Context: open-telemetry/opentelemetry-python#2266

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • Existing tests

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@owais owais requested a review from a team November 10, 2021 00:25
@owais owais added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 10, 2021
@owais owais force-pushed the remove-celery-special-case branch from 546be34 to 48ed73b Compare November 10, 2021 00:30
@owais owais merged commit f4d09f9 into open-telemetry:main Nov 10, 2021
@owais owais deleted the remove-celery-special-case branch November 10, 2021 11:48
@blumamir
Copy link
Member

blumamir commented Jan 8, 2022

Hi @owais ,
I am trying to investigate an issue with celery spans not being present on the worker process in python 3.6. Came across this PR which removed the support for it in sitecustomize.py in favor of register_at_fork.

Since this function is only introduced in 3.7, I wonder if there is any recommended initialization pattern with auto-instrument that will make it work with python 3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants