Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add pika instrumentation #680

Merged
merged 21 commits into from
Oct 6, 2021
Merged

Feature/add pika instrumentation #680

merged 21 commits into from
Oct 6, 2021

Conversation

oxeye-nikolay
Copy link
Member

@oxeye-nikolay oxeye-nikolay commented Sep 14, 2021 •
edited
Loading

Description

Added a new instrumentor for the pika module - python RabbitMQ library.

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test instrumentation API and individual channel instrumentation.

Does This PR Require a Core Repo Change?

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@oxeye-nikolay oxeye-nikolay requested a review from a team September 14, 2021 14:16
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 14, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@lzchen
Copy link
Contributor

lzchen commented Sep 20, 2021

@oxeye-nikolay

Following the expectations from contributors, would it be alright if you were made a CODEOWNER for this package?

lzchen
lzchen reviewed Sep 20, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@lzchen
Copy link
Contributor

lzchen commented Sep 23, 2021

@oxeye-nikolay
I believe you need to sign the CLA.

@oxeye-nikolay oxeye-nikolay mentioned this pull request Sep 29, 2021
Merged
6 tasks
@adirmatzkin adirmatzkin mentioned this pull request Oct 5, 2021
Closed
@owais owais enabled auto-merge (squash) October 6, 2021 15:34
auto-merge was automatically disabled October 6, 2021 16:29

Head branch was pushed to by a user without write access

@owais owais merged commit fb24599 into open-telemetry:main Oct 6, 2021
@lzchen lzchen mentioned this pull request Oct 6, 2021
Merged
11 tasks
@oxeye-nikolay oxeye-nikolay mentioned this pull request Oct 14, 2021
Closed
6 tasks
@nikosokolik nikosokolik mentioned this pull request Oct 25, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owais owais owais left review comments

@lzchen lzchen lzchen approved these changes

@ocelotl ocelotl ocelotl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oxeye-nikolay @lzchen @owais @ocelotl