-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Doc for aws propagator default sampling behavior #656
Update Doc for aws propagator default sampling behavior #656
Conversation
Can you review your own PR? :) @NathanielRN ? |
Ah that's a good point @owais 🙃 That's probably why the CODEOWNERS reviewer didn't work 😅 I'll close this then 🙂 |
I can still merge it for you as a maintainer if you re-open |
Until update the check to only require it if you are not the author or add another AWS person as codeowner on your recommendation. |
Thanks a ton for that! 😄 I think I can get a colleague at AWS to open the PR for me so we can test the CODEOWNER action out, but I appreciate your help with this! 🙂 |
73f3d7d
to
f6c8ba6
Compare
@lzchen An update on the CODEOWNERS action. With the change in #659 I will now get assigned even if I am the one who opened the PR (I still can't review though). However, I noticed that if I try to amend a commit, the "Component Owner" action fails as seen on this workflow. I filed this issue on the action repo and mentioned that maybe the solution is to not run on the |
f6c8ba6
to
d96681a
Compare
Description
By default the
TraceProvider
uses a Sampler which respects the Parent Sampling decision. If the user does not provideSampled=1;
into theirX-Amzn-Trace-Id
header when using theAwsXrayFormat
propagator, the parent context (and all subsequent child spans) are assumed to besampled=false
by default.This PR updates the docs to warn users about that.
Fixes #649
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
N/A
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.
- [ ] Changelogs have been updated- [ ] Unit tests have been added